Skip to content

Improve performance when setting RC defaults #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 5, 2022
Merged

Improve performance when setting RC defaults #469

merged 5 commits into from
Oct 5, 2022

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Sep 21, 2022 •
edited
Loading

Description

Provide details of the change, and generalize the change in the PR title above.

Setting defaults in remote config had unnecessarily duplication of strings when passing the values into C++, so reduce that where possible.

Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/3184057285

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Suggested by #462

@a-maurice a-maurice requested a review from DellaBitta October 5, 2022 01:05
@a-maurice a-maurice marked this pull request as ready for review October 5, 2022 01:05
@a-maurice a-maurice merged commit 6462c92 into main Oct 5, 2022
@a-maurice a-maurice deleted the am-improve_rc branch October 5, 2022 16:40
@firebase firebase locked and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DellaBitta DellaBitta DellaBitta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @DellaBitta