Add new Auth APIs using AuthResult
#703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `PhoneAuthCredential.SmsCode` - 'PhoneAuthProvider.VerificationCompleted(PhoneAuthCredential)`
- `PhoneAuthProvider.GetCredential()` - `PhoneAuthProvider.VerifyPhoneNumber(PhoneAuthOptions, VerificationCompleted, VerificationFailed, CodeSent, CodeAutoRetrievalTimeOut)` - Add documentation for `PhoneAuthProvider.SmsCode`
Properly implement `AuthResult` and add the following methods which returns `Task<AuthResult>` - `FirebaseAuth.SignInWithCustomTokenAsync()` - `FirebaseAuth.SignInWithCredentialAsync()` - `FirebaseAuth.SignInWithProviderAsync()` - `FirebaseAuth.SignInAndRetrieveDataWithCredentialAsync()` - `FirebaseAuth.SignInAnonymouslyAsync()` - `FirebaseAuth.SignInWithEmailAndPasswordAsync()` - `FirebaseAuth.CreateUserWithEmailAndPasswordAsync()` - `FirebaseUser.ReauthenticateAndRetrieveDataAsync()` - `FirebaseUser.ReauthenticateWithProviderAsync()` - `FirebaseUser.LinkWithCredentialAsync()` - `FirebaseUser.LinkWithProviderAsync()` - `FirebaseUser.UnlinkAsync()` - `FirebaseUser.UpdatePhoneNumberCredentialAsync()` - Remove `SignInWithCredentialInternalAsync_DEPRECATED()` but to rewire it to the version returning `Future<User>` instead.
DellaBitta
reviewed
May 5, 2023
DellaBitta
approved these changes
May 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Properly implement
AuthResultand add the following methods which returnsTask<AuthResult>FirebaseAuth.SignInWithCustomTokenAsync()FirebaseAuth.SignInWithCredentialAsync()FirebaseAuth.SignInWithProviderAsync()FirebaseAuth.SignInAndRetrieveDataWithCredentialAsync()FirebaseAuth.SignInAnonymouslyAsync()FirebaseAuth.SignInWithEmailAndPasswordAsync()FirebaseAuth.CreateUserWithEmailAndPasswordAsync()FirebaseUser.ReauthenticateAndRetrieveDataAsync()FirebaseUser.ReauthenticateWithProviderAsync()FirebaseUser.LinkWithCredentialAsync()FirebaseUser.LinkWithProviderAsync()FirebaseUser.UnlinkAsync()FirebaseUser.UpdatePhoneNumberCredentialAsync()Remove
SignInWithCredentialInternalAsync_DEPRECATED()and rewireSignInWithCredentialInternalAsync()to the version returningFuture<User>instead.Testing
GHA
https://github.com/firebase/firebase-unity-sdk/actions/runs/4889351215
Type of Change
Place an
xthe applicable box: