Skip to content

Change the Messaging topic test to avoid accidental messages #805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

a-maurice
Copy link
Collaborator

@a-maurice a-maurice commented Jul 18, 2023

Description

Provide details of the change, and generalize the change in the PR title above.

Change the Messaging topic test to subscribe, send, and unsubscribe in the same test. This is to prevent accidentally receiving a topic test while running a different test. Ideally it would use a more unique test topic, but creating a test topic takes some time after creation before it can be used to send messages.


Testing

Describe how you've tested these changes.

https://github.com/firebase/firebase-unity-sdk/actions/runs/5604605972


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@a-maurice a-maurice requested a review from cynthiajoan July 18, 2023 23:46
@a-maurice a-maurice changed the title Use a unique topic in Messaging tests Change the Messaging topic test to avoid accidental messages Jul 19, 2023
@a-maurice a-maurice merged commit 11c0fdd into main Jul 19, 2023
@a-maurice a-maurice deleted the am-messaging_topic branch July 19, 2023 23:06
@firebase firebase locked and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants