Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firestore, web): change interop type of updateDoc to force the JS interop to keep the value #10491

Merged
merged 1 commit into from
Feb 20, 2023

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Feb 20, 2023

Description

The current implementation would work in debug mode but could be stripped away in some cases during compilation.

Related Issues

fixes #10475
fixes #10478
fixes #10483

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone merged commit c46c976 into master Feb 20, 2023
@Lyokone Lyokone deleted the fix/update branch February 20, 2023 10:15
@adar2378
Copy link

adar2378 commented Feb 20, 2023

Thanks for quick response. When will it be released? Any estimated time?

@firebase firebase locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.