Skip to content

Conversation

JaFeKl
Copy link

@JaFeKl JaFeKl commented Dec 12, 2024

just a small typo I came across while checking the function documentation

Copy link

google-cla bot commented Dec 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@SelaseKay SelaseKay changed the title Small Typo in function documentation of createUserWithEmailAndPassword docs(auth): fix typo in function documentation of createUserWithEmailAndPassword Dec 12, 2024
@SelaseKay
Copy link
Contributor

Hi @JaFeKl, thanks for the fix. Kindly sign the CLA.

@JaFeKl
Copy link
Author

JaFeKl commented Dec 17, 2024

I sgined the CLA

/// - Thrown if the user is no longer authenticated since his refresh token
/// has been expired
/// - **network-request-failed**:
/// - Thrown if there was a network request error, for example the user don't
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/// - Thrown if there was a network request error, for example the user don't
/// - Thrown if there was a network request error, for example, if the user doesn't

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JaFeKl - also still saying CLA hasn't been signed 🤔

@russellwheatley
Copy link
Member

Covered in this PR: #16815

@firebase firebase locked and limited conversation to collaborators Jul 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants