Skip to content

fix(cloud_firestore): remove get-write validation #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 10, 2020
Merged

fix(cloud_firestore): remove get-write validation #2919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d71ca1
fix(cloud_firestore): remove get-write validation
Ehesp Jul 9, 2020
354d64d
remove invalid test
Ehesp Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ...cloud_firestore_platform_interface/lib/src/method_channel/method_channel_transaction.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,20 +26,11 @@ class MethodChannelTransaction extends TransactionPlatform {
FirebaseFirestorePlatform.instanceFor(app: Firebase.app(appName));
}

int _documentGetCount = 0;

List<Map<String, dynamic>> _commands = [];

/// Returns all transaction commands for the current instance.
///
/// All get operations must be written, otherwise an [AssertionError] will be thrown
@override
List<Map<String, dynamic>> get commands {
if (_documentGetCount > 0) {
assert(_documentGetCount <= _commands.length,
"All transaction get operations must also be written.");
}

return _commands;
}

Expand All @@ -58,7 +49,6 @@ class MethodChannelTransaction extends TransactionPlatform {
'transactionId': _transactionId,
'reference': _firestore.doc(documentPath),
});
_documentGetCount++;

return DocumentSnapshotPlatform(
_firestore,
Expand Down
5 changes: 0 additions & 5 deletions ...restore_platform_interface/test/method_channel_tests/method_channel_transaction_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,11 +64,6 @@ void main() {
});

group('commands', () {
test('should throw if get is not written', () async {
await transaction.get(mockDocumentReference.path);
expect(() => transaction.commands, throwsAssertionError);
});

test('returns with equal checks', () async {
await transaction.get(mockDocumentReference.path);
transaction.set(mockDocumentReference.path, {'foo': 'bar'});
Expand Down