Skip to content

fix(firestore): add timestamp tests & fix #2945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 13, 2020
Merged

fix(firestore): add timestamp tests & fix #2945

merged 1 commit into from
Jul 13, 2020

Conversation

Ehesp
Copy link
Member

@Ehesp Ehesp commented Jul 13, 2020

Description

  • Ensures out of range math values are rounded down.
  • Adds Timestamp tests

Related Issues

Fixes #1222

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@Salakar Salakar changed the title add timestamp tests & fix fix(firestore): add timestamp tests & fix Jul 13, 2020
@Salakar Salakar merged commit 0ee5ab1 into master Jul 13, 2020
@Salakar Salakar deleted the @ehesp/timestamp-fix-1222 branch July 13, 2020 13:51
@firebase firebase locked and limited conversation to collaborators Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@Salakar Salakar Salakar approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cloud_firestore] Timestamp class miscalculates microseconds and milliseconds
3 participants
@Ehesp @Salakar @googlebot