Fixes for delete-unused-accounts-cron example #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Fix a typo in the option name: header -> headers This was causing the request for the service-account access token to fail with error: StatusCodeError: 403 - "Missing required header: Metadata-Flavor\n" 2) Specify json: true in the request options Without this option, the response was returned as a string and not parsed as json. Consequently, resp.access_token was undefined.
The filter predicate was selecting users who had logged in during the past month, whereas we want the opposite.
The user id property is called localId, not uid. The uid property is undefined.
|
Awesome @appleby thanks for all the testing and the fixes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains fixes needed to get the delete-unused-accounts-cron example working for me.
The CONTRIBUTING guide mentions running gulp build and tests before submitting a PR, but they don't seem to exist for this repo? Or I couldn't find them anyway, so I did manual testing following the setup instructions in the README file, namely:
git clone https://github.com/firebase/functions-samplescd functions-samples/delete-unused-accounts-cronfirebase use --addand follow the instructions.cd functions; npm install; cd -firebase functions:config:set cron.key="YOUR-KEY"firebase deploy.However, instead of using a third-party cron service to trigger the function, I just ran
curlfrom my laptop like so:During testing, I also reduced the inactive users interval from 30 days to 10 minutes to make it easier to verify that inactive user accounts get deleted.
See individual commit messages for more info on each change.