Move to pnpm #872
Merged
Move to pnpm #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuleatt
reviewed
May 25, 2021
| }, | ||
| "devDependencies": { | ||
| "eslint": "^6.8.0", | ||
| "eslint-plugin-promise": "^4.2.1", | ||
| "lerna": "^3.20.2", |
There was a problem hiding this comment.
Does this mean Lerna isn't needed at all any more? If so, want to remove lerna.json as well?
jhuleatt
reviewed
May 25, 2021
jhuleatt
approved these changes
May 25, 2021
jhuleatt
reviewed
May 25, 2021
Co-authored-by: Jeff <jhuleatt@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the samples significantly smaller and makes our CI run faster.
Size differences
Here are the sizes after running the bootstrap script:
lerna: 4.5GBpnpm:functions-samples~/.pnpm-storeSpeed differences
Overall
With lerna our CI tests take ~7m, with ~4m in the bootstrap phase (link):
With pnpm with no concurrency our CI tests take ~4m with ~0.5m in the bootstrap phase (link):
With pnpm with concurrency set to 8 (same as Lerna) our CI tests take 3.5m (link):
With pnpm with concurrency set to 4 our CI tests take 4.25m (link):