Skip to content
This repository was archived by the owner on Dec 29, 2022. It is now read-only.

Conversation

samtstern
Copy link
Contributor

No description provided.

@samtstern
Copy link
Contributor Author

Right now I get the following test failure:

GeoQueryTest.dataChanged:145 
  expected:<[
    DATA_MOVED(1,37.000100,-122.000000), 
    DATA_CHANGED(1,37.000100,-122.000000), 
    DATA_MOVED(4,37.000200,-122.000000), 
    DATA_CHANGED(4,37.000200,-122.000000), 
    DATA_CHANGED(2,37.000100,-122.000100)]> 

  but was:<[
    DATA_MOVED(1,37.000100,-122.000000),
    DATA_CHANGED(1,37.000100,-122.000000),
    DATA_MOVED(4,37.000200,-122.000000),
    DATA_CHANGED(4,37.000200,-122.000000),
    DATA_CHANGED(1,37.000100,-122.000000), <-- ???
    DATA_CHANGED(4,37.000200,-122.000000), <-- ???
    DATA_CHANGED(2,37.000100,-122.000100)]>

I am getting an extra changed event for each of the moved locations. TBD why.

@samtstern
Copy link
Contributor Author

Note: the earlier test failures a result of this bug in the Java SDK
firebase/firebase-admin-java#116

Since it is fixed on Android and is not that harmful of a bug anyway, going to move forward here.

@samtstern samtstern merged commit 1916675 into master Dec 21, 2017
Copy link
Contributor

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks 👍

@samtstern samtstern deleted the geo-data-listener-tests branch December 22, 2017 18:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants