Migrate to functions v2 #168
Conversation
There was a problem hiding this comment.
I would revert all the "/v2" sort of migrations--this codebase is already on V2 which has been the default for a while.
As a design pattern I might make a params/config namespace where you've exported all your params (they're immutable, so you should be OK providing direct const access). Then when you're initializing globals, you should do so in an onInit callback, during which params can be safely accessed.
| const emailDebug = params.defineBoolean("EMAIL_DEBUG"); | ||
| const emailGroup = params.defineString("EMAIL_GROUP"); | ||
|
|
||
| export function getGitHubToken(): string { |
There was a problem hiding this comment.
What is the purpose of these helpers? Is this a common enough need that we should take feedback for the Functions SDK?
There was a problem hiding this comment.
I just wanted them to be named so I didn't have to call params.defineString(string) everywhere. Some of these are used only once so I'm not really saving any work in those cases.
morganchen12
force-pushed
the
mc/functions-v2
branch
from
5cf5fbc to
a18c17f
Compare
No description provided.