Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support RS384 and RS512 #117

Merged
merged 1 commit into from Jun 19, 2017
Merged

Support RS384 and RS512 #117

merged 1 commit into from Jun 19, 2017

Conversation

@joostfaassen
Copy link

joostfaassen commented Oct 10, 2016

No backward compatibility breaks, just add support for RS384 and RS512 algorithms.

This should help tick more boxes on jwt.io

I've just signed the CLA

@cwhite92

This comment has been minimized.

Copy link

cwhite92 commented Jun 19, 2017

It's a real shame that this one isn't getting merged... it's exactly what I need right now. :(

@robertdimarco

This comment has been minimized.

Copy link
Member

robertdimarco commented Jun 19, 2017

Sorry for the delay; let's get this done. I'll merge this now and get a release published later today.

Thanks for the contribution!

@robertdimarco robertdimarco merged commit 7f72b48 into firebase:master Jun 19, 2017
2 checks passed
2 checks passed
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cwhite92

This comment has been minimized.

Copy link

cwhite92 commented Jun 19, 2017

@robertdimarco very much appreciate you taking a look at this, thanks! 👍

@robertdimarco

This comment has been minimized.

Copy link
Member

robertdimarco commented Jun 19, 2017

Better late than never, right? =/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.