-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add resource type as 2nd param in decode method #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix Parameter #2 $key of static method Firebase\JWT\JWT::decode() expects array|string, resource given.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Anybody, merge please |
I've updated PR and resolved conflicts. @bshaffer, please, take a look |
This is great, thanks! And we got it merged in just under 2 years! |
It's a minor clarification of input parameters in
JWT::decode
method.Second parameter (key) accepts arrays, strings and resources, but in PHPDoc resource type is not listed.
Let's take a look at an example:
If I run static analysis with PHPStan, I will get the following error: