Checking the token expiry time #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking if our token has expired.
|
👍 What about a unit test for that? |
|
Here are the unit tests. Cheers |
SelviA
pushed a commit
to SelviA/php-jwt
that referenced
this pull request
Mar 7, 2023
Make getBaseLogoutUrl private Make getBaseLogoutUrl private
SelviA
pushed a commit
to SelviA/php-jwt
that referenced
this pull request
Mar 7, 2023
Fix firebase#5 - Expose logout URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if our token has expired.
I am not sure if this is the best place to put such logic, in case you have a better suggestion please let me know.