Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove null as possible key value in docblock #76

Merged
merged 1 commit into from Jun 16, 2016

Conversation

@akeeman
Copy link

akeeman commented Dec 30, 2015

The docblock states that null is a possible value for $key, however, it clearly results in an exception.

The docblock states that null is a possible value for $key, however, it clearly results in an exception.
@googlebot

This comment has been minimized.

Copy link

googlebot commented Dec 30, 2015

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.
@googlebot googlebot added the cla: no label Dec 30, 2015
@akeeman

This comment has been minimized.

Copy link
Author

akeeman commented Dec 30, 2015

I signed it!

@robertdimarco robertdimarco merged commit e72feba into firebase:master Jun 16, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.