Update Android build config and source fixes #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DellaBitta
commented
Jul 6, 2022
| @@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| zipStoreBase=GRADLE_USER_HOME | |||
| zipStorePath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-4.6-all.zip | |||
There was a problem hiding this comment.
I'm not sure what the extra \ is for. It works, I guess, but it's not in our main repo so I'm removing it here.
DellaBitta
requested review from
jonsimantov,
vimanyu and
cynthiajoan
and removed request for
vimanyu
cynthiajoan
approved these changes
Jul 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A pass of the android build process to ensure the testapps can build prior to adding CI to the repo.
Changes include:
Updates to the repo to reconcile testapp Android build configuration discrepencies when compared to the firebase-cpp-sdk repo's integration tests, including:
Updates to test sources.