Don't use deprecated EventListener class. #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var-const
suggested changes
Jul 21, 2021
ehsannas
force-pushed
the
ehsann/remove-event-listener
branch
from
9a9d28e to
32381ed
Compare
ehsannas
force-pushed
the
ehsann/remove-event-listener
branch
from
32381ed to
9ee9260
Compare
var-const
approved these changes
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have separated the PR into 2 commits. The first is only formatting changes applied by clang-format. The second is the one needed for a successful compilation since EventListener has been removed from the public API.