Skip to content

Add remote config snippets #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 31, 2022
Merged

Add remote config snippets #352

merged 8 commits into from
May 31, 2022

Conversation

thatfiredev
Copy link
Member

This PR should add Remote Config snippets to this repository. All of these snippets are coming from quickstart-android.

@thatfiredev thatfiredev requested a review from marinacoelho May 30, 2022 13:15
@thatfiredev thatfiredev changed the title add remote config snippets [WIP] add remote config snippets May 30, 2022
@thatfiredev
Copy link
Member Author

I just realized I made a mistake here. The new config snippets directory should be a project, but I have created a module instead. I'll fix it in a few.

@thatfiredev thatfiredev removed the request for review from marinacoelho May 30, 2022 13:29
@thatfiredev thatfiredev changed the title [WIP] add remote config snippets Add remote config snippets May 30, 2022
@thatfiredev thatfiredev requested a review from marinacoelho May 30, 2022 17:34
@@ -0,0 +1,100 @@
@rem
@rem Copyright 2015 the original author or authors.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add the copyrights as 2022?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These gradle scripts belong to their respective authors and not to us.
When a new project is created in Android Studio (even in the most recent versions of it) these scripts still show up with 2015 copyrights.

@marinacoelho
Copy link
Contributor

LGTM - with one comment only.

@thatfiredev thatfiredev enabled auto-merge (squash) May 31, 2022 14:14
@thatfiredev thatfiredev merged commit 6e22859 into master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants