Skip to content

feat: demonstrate asking for post notification permission #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 22, 2022

Conversation

kroikie
Copy link
Contributor

@kroikie kroikie commented Jun 22, 2022

Add snippets of requesting and handling the result of a POST_NOTIFICATION permission request.

@kroikie kroikie requested review from thatfiredev and egilmorez June 22, 2022 17:57
Copy link

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG with nits!

I will crib some of the guidance in the comments for the guide page.

Copy link

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; same nits for Kotlin as for Java. Thanks!

@kroikie kroikie merged commit 7127256 into master Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants