initial action complete #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see any changes in snippets that are in the docs here, so LGTM |
puf
reviewed
Mar 24, 2022
| @@ -80,7 +80,7 @@ class DefaultFirebaseOptions { | |||
| messagingSenderId: 'TODO: use secrets or demo', | |||
There was a problem hiding this comment.
Did we always have these TODO's here? I'd prefer to not use the word "secret" here, as these are configuration values and not secrets (see https://stackoverflow.com/a/37484053). While it is a common practice to not commit these configuration values (to prevent getting into each other's way it's often best for every dev to set up their own project), it'd be better to describe at a file-level why that is.
There was a problem hiding this comment.
Whoa, that SO answer is news to me. I shall update on a future PR.
puf
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of what this PR is changing or adding, and why: