Skip to content

Conversation

petermiles
Copy link
Contributor

On line 567, the argument 'colleciton' is passed as an argument into the forEach function.
The argument should be 'collection', just a small typo.

I've went ahead and fixed this typo.

On line 567, the argument 'colleciton' is passed as an argument into the forEach function.
The argument should be 'collection', just a small typo.

I've went ahead and fixed this typo.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@samtstern
Copy link
Contributor

@petermiles thanks for catching this! Will merge once CLA bot is happy.

@petermiles
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@samtstern samtstern merged commit 7dec099 into firebase:master Jan 24, 2018
@samtstern
Copy link
Contributor

@petermiles thanks for contributing!

@petermiles petermiles deleted the patch-1 branch January 24, 2018 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants