-
Notifications
You must be signed in to change notification settings - Fork 11
build: Relax pydantic version requirement #332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is there any work going on for this PR? I'm using |
Hi. Yes, just need to update it to reflect new changes in the main. Should be able to get to it in a couple of days. |
Thanks! Looking forward to release. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Released in 1.2.2 |
Part of refactoring needed for MWAA(managed airflow) support in FIR-28712
This way we'll be able to support both legacy and the latest managed Airflow deployment.
Ticket FIR-29465
Note: there's a difference between pydantic validation and mypy validation of pydantic models. The former respects
populate_by_name
andallow_population_by_field_name
and the latter does not understand it. Installing pydantic.mypy plugin reverses this, it assumes either alias is correct or the kay. There's some discussion in mypy about this but basically nothing will change until v3.Currently, it's safe to assume pydantic will populate data from the server correctly even if it comes with aliases, but for the code initialisation we're sticking to keys.