-
Notifications
You must be signed in to change notification settings - Fork 11
test: Fir 29921 add inf and nan tests to python sdk #351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fir 29921 add inf and nan tests to python sdk #351
Conversation
ab30825
to
9c28972
Compare
), "Invalid bytea data returned after roundtrip" | ||
|
||
|
||
@fixture(scope="session") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to change this? It's scoped to session if we need to reuse the database, but it's not autoused so only relevant tests will invoke it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixture failed for me since it's using connection_system_engine_no_db
, which itself is per test scoped. This causes pytest to fail. I'm not sure how it used to work and if it's related to my changes. I'll take a look
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the error I get locally on the main now: ScopeMismatch: You tried to access the function scoped fixture connection_system_engine_no_db with a session scoped request object, involved factories:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on github CI because currently the use_database test (which is the one that uses this fixture) is skipped for staging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. That's annoying :(
My worry here is if we reuse this fixture it might run into race condition when one test is trying to delete a db and another one to use it. Maybe let's add a few random numbers just to be safe?
Integration tests are passing: https://github.com/firebolt-db/firebolt-python-sdk/actions/runs/7869763880 |
67ab6cf
to
0c926b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise lgtm
), "Invalid bytea data returned after roundtrip" | ||
|
||
|
||
@fixture(scope="session") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. That's annoying :(
My worry here is if we reuse this fixture it might run into race condition when one test is trying to delete a db and another one to use it. Maybe let's add a few random numbers just to be safe?
|
common
module