Skip to content

ci(NoTicket): Use shared PR title action #413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 20, 2025
Merged

ci(NoTicket): Use shared PR title action #413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
75aa29a
ci: Test formatter
ptiurin Jan 17, 2025
7c20133
use branch
ptiurin Jan 17, 2025
819590a
add edited check
ptiurin Jan 17, 2025
fdc113c
rerun everything
ptiurin Jan 17, 2025
4eadc84
clearner way
ptiurin Jan 17, 2025
5c4200b
test internal
ptiurin Jan 17, 2025
d98cc9f
test event
ptiurin Jan 17, 2025
dcbb507
print info
ptiurin Jan 17, 2025
bbaeac6
another test
ptiurin Jan 17, 2025
68306f0
another test
ptiurin Jan 17, 2025
f765f3c
revert test changes
ptiurin Jan 17, 2025
37f64fe
switch to main for formatting action
ptiurin Jan 20, 2025
5e4eecb
Merge branch 'main' into test-formatter
ptiurin Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .github/workflows/check-pr-formatting.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
name: Pull request formatting

on:
pull_request:
branches: [ main, 0.x ]
types: [opened, synchronize, edited]

jobs:
pr-formatting:
runs-on: ubuntu-latest
steps:
- name: Formatting conventions
uses: firebolt-db/action-pr-checks@main
with:
github-key: ${{ secrets.GITHUB_TOKEN }}
9 changes: 1 addition & 8 deletions .github/workflows/pull-request.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
name: Pull request
name: Pull request code checks

on:
pull_request:
branches: [ main, 0.x ]

jobs:
check-title:
runs-on: ubuntu-latest
steps:
- name: Check title name convention
uses: jef/conventional-commits-pr-action@v1.0.0
with:
token: ${{ secrets.GITHUB_TOKEN }}
code-checkers:
uses: ./.github/workflows/code-check.yml
unit-tests:
Expand Down
Loading