Skip to content

feat(FIR-43324): async cancellation method #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 11, 2025
Merged

feat(FIR-43324): async cancellation method #420

merged 4 commits into from
Feb 11, 2025

Conversation

ptiurin
Copy link
Contributor

@ptiurin ptiurin commented Feb 6, 2025 •
edited
Loading

This allows seamlessly cancel a running query

@ptiurin ptiurin marked this pull request as ready for review February 6, 2025 16:24
@ptiurin ptiurin requested a review from a team as a code owner February 6, 2025 16:24
stepansergeevitch
stepansergeevitch approved these changes Feb 10, 2025
View reviewed changes
Copy link
Collaborator

@stepansergeevitch stepansergeevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ptiurin ptiurin merged commit 3d92df9 into main Feb 11, 2025
8 checks passed
@ptiurin ptiurin deleted the feat-add-query-cancel branch February 11, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stepansergeevitch stepansergeevitch stepansergeevitch approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ptiurin @stepansergeevitch