Skip to content

chore(FIR-42243): Mark cursor.query_id as not populated in docstring #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2025
Merged

chore(FIR-42243): Mark cursor.query_id as not populated in docstring #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/firebolt/common/cursor/base_cursor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ def __init__(
# Server-side parameters (user can't change them)
self.parameters: Dict[str, str] = dict()
self.engine_url = ""
self._query_id = ""
self._query_id = "" # not used
self._query_token = ""
self._row_set: Optional[BaseRowSet] = None
self._reset()
Expand Down Expand Up @@ -149,7 +149,11 @@ def rowcount(self) -> int:
@property # type: ignore
@check_not_closed
def query_id(self) -> str:
"""The query id of a query executed asynchronously."""
"""
Deprecated: This property is not populated anymore and is left for
backward compatibility.
"""
# FIR-42243
return self._query_id

@property
Expand Down