feat(FIR-46249): Firebolt Core support #434
Conversation
|
|
||
| # Parse URL | ||
| try: | ||
| parsed = urlparse(url) |
There was a problem hiding this comment.
nit: Might be a super rare case, but if we find any url path or parameters present let's log a warning saying it will be ignored.
There was a problem hiding this comment.
We're actually passing down everything right now, query parameters and path. IMO, it's up to the Core to filter those out. If the user has a server on top of the Core that takes in some parameters and based on them reroutes the request then they can work with the sdk out of the box.
Just checked and Core raises an error if extra query parameters are passed. However, it allows any path e.g. http://localhost:3473/my_awesome/path returns the same results as http://localhost:3473/
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
2 participants
Adding support for Firebolt Core.
Core does not have authentication, multiple accounts or engines.
Adding changes to the tests to run all the V2 DBAPI tests against core as well, by adding "core" filter.