feat(FIR-46254): Extend caching #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepansergeevitch
approved these changes
Aug 12, 2025
|
stepansergeevitch
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change caching to include system engine, database and user engine. This also changes the key to be in line with our new caching design - id + secret + account.
In addition, this change added caching hit tracking by using ID.
Key changes include:
Caching System and Connection Management:
ConnectionInfo,EngineInfo,DatabaseInfo,SecureCacheKey) to store system engine, engine, and database info per connection, replacing the previous global cache. This enables per-connection context caching and improves performance for repeated context switches. (src/firebolt/async_db/connection.py)Connectionclass to include a uniqueidfor each connection instance, used as a key in the cache. (src/firebolt/async_db/connection.py[1] [2]Authentication Refactoring:
principalandsecretproperties to all authentication classes, standardizing how credentials are accessed for caching and tracking purposes.Cursor Enhancements:
use_databaseanduse_enginemethods to the cursor, supporting context switching with optional cache usage. These methods now check the cache before executing context switch queries, reducing unnecessary round-trips. (src/firebolt/async_db/cursor.pysrc/firebolt/async_db/cursor.pyR336-R370)