DomTree items are not expandable

[janodvarko]

STR:

1. Load any page e.g. https://getfirebug.com/tests/manual/console/joes-original/test.html
2. Open the toolbox and select the DOM panel
3. Click to expand a tree item (e.g. frame), it isn't expanded -> BUG

This is because repObject property is not set to the target row.
Here is where Domplate generates string for eval
https://github.com/firebug/firebug.next/blob/master/lib/core/domplate.js#L526

Here is where it's not set:
https://github.com/firebug/firebug.next/blob/master/lib/dom/domTree.js#L140

@simonlindholm: this might be related to global scope/eval/wrappers, do you have any tips? Also sounds like related to issue #14

Honza

[janodvarko]

The panel's iframe is set to "content" and can't reference object from the chrome.

I did a workaround for the DomSidePanel now (set the iframe's type to chrome), but we need to use proper channel for communication between chrome <-> iframe

There is DebugClient example in Add-on SDK.

Honza

[janodvarko]

The previous commit solves the problem by loading the DOM panel content (iframe URL) from chrome. This cause the panel-frame to use chrome privileges.
However, using chrome privileges sounds more like a workaround and we might want to find better concept.

Honza

[simonlindholm]

Yeah, it should be possible to get it to work as long as we make sure to run all scripts from chrome. (I've been meaning to look at this, just have had no time at all for firebug.next things. Might get better in September, hopefully.)

[janodvarko]

Note that part of the problem is that chrome script can't set "_repObject" property on a content node.

Honza

[janodvarko]

Note that part of the problem is that chrome script can't set "_repObject" property on a content node.

Honza

[janodvarko]

@simonlindholm: are you interested in this one or should I fix it?

Honza

[simonlindholm]

Was planning to look at it in a few days, actually. Time has mostly freed up now, so it's mainly a question of getting back into things.

[janodvarko]

ok, great!

Honza

[simonlindholm]

BTW, do we still need a Selector panel given https://bugzilla.mozilla.org/show_bug.cgi?id=971662 ?