Toolbox options button is not visible

[janodvarko]

There should be a button on the main toolbox toolbar that allows to open toolbox options. The button is not visible at the moment (but it's there). See attached screenshot:

Also, the tab panel options menu image (the little black triangle) should not be applied on this button.

Honza

[janodvarko]

@kaljak: Jakob, are you interested to take a look at this one? (good-first-bug to start with)

Honza

[kaljak]

Thanks Honza for "Hacking on Firebug.next" - I think everything is working \o/

So I did fix this issue with this commit: https://github.com/kaljak/firebug.next/commit/e736269f499d450d35ca938d4fc3230be54714e4

Some problems I had:

• Browsertoolbox isn't showing any styles that we define... Did I miss something here?
• I guess the button should have the same hovereffect as the other buttons in the toolbar, right?

[janodvarko]

So I did fix this issue with this commit
Nice! Please commit into the master or send a pull request.

Browsertoolbox isn't showing any styles that we define...
Sounds like a bug. There is "browser styles" checkbox in the Computed panel, but it doesn't helps the Rules panel. You can report a bug in bugzilla (or search for an existing).

I guess the button should have the same hovereffect as the other buttons in the toolbar, right?
Right

Also, there shouldn't be the option icon (the little black triangle) associated with the options button.
I don't know what the best solution is, but you could do a condition in tabMenu.js module
within initialize:

if (panelId == "options")
return;

Or something...

Honza

[kaljak]

For the hover-effect:
Everything would be fine, if the button (#toolbox-tab-options) wouldn't be a "radio"-element but a "toolbarbutton"-element.
Is that somehow do-able?

Thanks in advance,
Jakob

[janodvarko]

Any chance for a workaround?

Otherwise please create a bugzilla bug and explain why it's hard to do a new theme.
(and cc me, please)

Honza

[kaljak]

I think I did fix this issue:
d734b3c

Please review :)

[janodvarko]

Yep, great, the button is now visible.

One comment, if it's selected the icon is almost not visible. Could you fix that?

Honza

[kaljak]

Hey Honza,
fixed here: f0b7efa

[SebastianZ]

You mean here:
dbf70a8

Sebastian

[kaljak]

Thank you, yes I mean there ^^

[janodvarko]

Awesome, thanks, a lot better now!

(you can close this issue I guess)

Honza