Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Animations side panel layout fit more to Firebug #424

Open
SebastianZ opened this issue Oct 29, 2015 · 5 comments
Open

Make Animations side panel layout fit more to Firebug #424

SebastianZ opened this issue Oct 29, 2015 · 5 comments

Comments

@SebastianZ
Copy link
Member

The timeline within the Animations side panel looks a bit ugly and doesn't really fit to the general Firebug layout.

Animations side panel not looking firebuggy

Tasks:

Sebastian

@compojoom
Copy link

@janodvarko would you please advise me how to fix this?
I have followed the developer guide and now I'm running Firefox with firebug from git. I saw that you've addressed some of the problems in this issue
ff-animations
fb-animations

But it's actually not fully fixed. When we hover with the mouse over the pause button in near the timeline - the hover state is invisible.

Also as you can see from the ff-animations screenshot -> the inspector tools is showing a rewind icon. With the browser tools I saw that the markup is there.
markup

Some of the buttons are falling behind the progressbar and also we don't have any images for those. What are the guidelines here? Where are we taking the images from?

@SebastianZ
Copy link
Member Author

You're obviously using the wrong version of Firefox. Ensure that you're running Nightly. Then the Animations side panel should look like this:

Animations side panel

To do that you need to define the Firefox binary via the -b parameter when you call jpm.

Sebastian

@compojoom
Copy link

@SebastianZ - aaaah. okay! Thanks!

So, it seems that this issue is actually fixed?

@SebastianZ
Copy link
Member Author

So, it seems that this issue is actually fixed?

No, as mentioned above the current style doesn't fit to the general Firebug layout. E.g. Firebug doesn't have striped bars anywhere. So the tasks listed in the first post are still valid.

Sebastian

@fflorent
Copy link
Member

@compojoom Hello. Thanks for being interested in this issue!

Do you need some help / information of any form?

Florent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants