Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: monitor WebIDE RDP connections #60

Merged
merged 5 commits into from
Aug 19, 2015

Conversation

rpl
Copy link
Member

@rpl rpl commented Aug 3, 2015

This pull request (related to the issue #52) introduces a new preference (and the related option in the start button menu) which enables monitoring of the WebIDE RDP connections.

If the preference is enabled a new RDPinspector window will be opened (it can be recognized by window title, which includes the WebIDE selected runtime name)

gifrecord_2015-08-03_202213

this.onDestroyConnection = this.onDestroyConnection.bind(this);

this.transportObservers = new Map();
this.transportListeners = new Map();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither transportObservers nor transportListeners are used, should we remove it?

@janodvarko
Copy link
Member

Overall this is great progress!

My main concern is the UI/UX.

Currently if you open RDPi window with WebIDE you can't inspect RDP communication for a Toolbox. Similar problem was there already before, it isn't possible to intercept packets for the second opened Toolbox.

I think we still need a drop-down list (a combo-box) with list of all available connections (including Toolbox and WebIDE connections) displayed at the top of the RDPi window allowing the user to pick a connection to observe...

I am thinking about the following use cases:

A RDPi opened when there is no connection

  1. The user opens RDPi console. There is neither Toolbox nor WebIDE open, so the console is empty since there is no connection available (the list of connections is also empty). Opening the console does not open the Toolbox automatically.
  2. The user opens the Toolbox. The list of connections has automatically one entry. Since it's the first connection it's auto-selected, so the console automatically displays RDP traffic for the Toolbox.

Q: we could auto-select connection in the list according to the currently selected toolbox (can be a follow up).

B RDPi opened when there is a connection

  1. The user opens the Toolbox (or more than one)
  2. The user opens RDPi console. If there is just one connection it's automatically selected and the console displays RDP traffic for it. If there are more connections, the first one in the list is selected automatically.

Further comments:

  • The list of connections is updated automatically as a Toolbox and/or WebIDE are opened or closed.
  • If active connection is closed another one from the list (the first one?) is automatically selected.
  • Connection label should clearly indicate what window is associated with it (e.g. using nice prefix "Toolbox/WebIDE" or window title just like now).
  • The user should be able to explicitly open two RDPi consoles to observer two connections at the same time (but this should be probably done as a follow up)

Honza

janodvarko added a commit that referenced this pull request Aug 19, 2015
Feature: monitor WebIDE RDP connections
@janodvarko janodvarko merged commit a561523 into firebug:master Aug 19, 2015
This was referenced Aug 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants