-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: monitor WebIDE RDP connections #60
Conversation
this.onDestroyConnection = this.onDestroyConnection.bind(this); | ||
|
||
this.transportObservers = new Map(); | ||
this.transportListeners = new Map(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neither transportObservers nor transportListeners are used, should we remove it?
Overall this is great progress! My main concern is the UI/UX. Currently if you open RDPi window with WebIDE you can't inspect RDP communication for a Toolbox. Similar problem was there already before, it isn't possible to intercept packets for the second opened Toolbox. I think we still need a drop-down list (a combo-box) with list of all available connections (including Toolbox and WebIDE connections) displayed at the top of the RDPi window allowing the user to pick a connection to observe... I am thinking about the following use cases: A RDPi opened when there is no connection
Q: we could auto-select connection in the list according to the currently selected toolbox (can be a follow up). B RDPi opened when there is a connection
Further comments:
Honza |
- add prefs and start menu option - auto-open RDP inspector window with custom title
- removed unused vars - removed enforce minimum window size
Feature: monitor WebIDE RDP connections
This pull request (related to the issue #52) introduces a new preference (and the related option in the start button menu) which enables monitoring of the WebIDE RDP connections.
If the preference is enabled a new RDPinspector window will be opened (it can be recognized by window title, which includes the WebIDE selected runtime name)