Drive Permissions are not Updated on PUT with Same ID

[andreeaflorescu]

Update was implemented and all fields of the drive are updated except the drive permissions. We should also update that field as part of the PUT.

[alxiord]

Looks like they are in fact updated, have you spotted any weird behavior?

impl BlockDeviceConfigs {
    ...
    pub fn update(&mut self, block_device_config: &BlockDeviceConfig) -> Result<()> {
        ...
        cfg.is_read_only = block_device_config.is_read_only;

$ curl --unix-socket /tmp/firecracker.socket -i  \
      -X PUT "http://localhost/boot-source" \
      -H "accept: application/json" \
      -H "Content-Type: application/json" \
      -d "{ 
            \"boot_source_id\": \"alinux_kernel\",
            \"source_type\": \"LocalImage\", 
            \"local_image\": 
                 { 
                     \"kernel_image_path\": \"${kernel_path}\" 
                 },
    \"boot_args\": \"console=ttyS0 noapic reboot=k panic=1 pci=off nomodules\"
         }"
HTTP/1.1 201 Created
Content-Length: 0
Date: Mon, 11 Jun 2018 08:11:43 GMT

$ curl --unix-socket /tmp/firecracker.socket -i \
      -X PUT "http://localhost/machine-config" \
      -H "accept: application/json" \
      -H "Content-Type: application/json" \
      -d "{ \"vcpu_count\": 4, \"mem_size_mib\": 256}"
HTTP/1.1 204 No Content
Date: Mon, 11 Jun 2018 08:11:43 GMT

$ curl --unix-socket /tmp/firecracker.socket -i \
      -X PUT "http://localhost/drives/root" \
      -H "accept: application/json" \
      -H "Content-Type: application/json" \
      -d "{ 
             \"drive_id\": \"root\",
             \"path_on_host\": \"${rootfs_path}\", 
             \"is_root_device\": true, 
             \"permissions\": \"rw\", 
             \"state\": \"Attached\"
          }"
HTTP/1.1 201 Created
Content-Length: 0
Date: Mon, 11 Jun 2018 08:11:43 GMT

Add RO drive

$ curl --unix-socket /tmp/firecracker.socket -i \
      -X PUT "http://localhost/drives/read_only_drive" \
      -H "accept: application/json" \
      -H "Content-Type: application/json" \
      -d "{ 
             \"drive_id\": \"read_only_drive\",
             \"path_on_host\": \"${ro_drive_path}\", 
             \"is_root_device\": false, 
             \"permissions\": \"ro\", 
             \"state\": \"Attached\"
          }"
HTTP/1.1 201 Created
Content-Length: 0
Date: Mon, 11 Jun 2018 08:11:43 GMT

Update to RW

$ curl --unix-socket /tmp/firecracker.socket -i \
      -X PUT "http://localhost/drives/read_only_drive" \
      -H "accept: application/json" \
      -H "Content-Type: application/json" \
      -d "{ 
             \"drive_id\": \"read_only_drive\",
             \"path_on_host\": \"${ro_drive_path}\", 
             \"is_root_device\": false, 
             \"permissions\": \"rw\", 
             \"state\": \"Attached\"
          }"
HTTP/1.1 204 No Content
Date: Mon, 11 Jun 2018 08:11:43 GMT

$ curl --unix-socket /tmp/firecracker.socket -i \
      -X PUT "http://localhost/network-interfaces/1" \
      -H "accept: application/json" \
      -H "Content-Type: application/json" \
      -d "{ 
             \"iface_id\": \"1\", 
             \"host_dev_name\": \"vmtap33\", 
             \"guest_mac\": \"06:00:00:00:00:01\", 
             \"state\": \"Attached\" 
         }"
HTTP/1.1 201 Created
Content-Length: 0
Date: Mon, 11 Jun 2018 08:11:43 GMT

$ curl --unix-socket /tmp/firecracker.socket -i \
      -X PUT "http://localhost/actions/start" \
      -H  "accept: application/json" \
      -H  "Content-Type: application/json" \
      -d "{  
             \"action_id\": \"start\",  
             \"action_type\": \"InstanceStart\"
          }"
HTTP/1.1 201 Created
Content-Length: 0
Date: Mon, 11 Jun 2018 08:11:43 GMT

Guest

[root@localhost ~]# lsblk 
NAME MAJ:MIN RM  SIZE RO TYPE MOUNTPOINT
vdb  254:16   0  200M  0 disk 
vda  254:0    0    2G  0 disk /