Skip to content

Misleading comment about where the queue starts and its size #4997

@MatiasVara

Description

@MatiasVara

Hello,

IIUC, the virtqueue starts at QUEUE_BASE_ADDRESS, which is not 0. So the comment shall state that. The comment is at

/// The address of the first byte after the queue. Since our queue starts at guest physical

Also QUEUE_END is not the size if the starting address is not zero so the definition at

const GUEST_MEMORY_SIZE: usize = QUEUE_END as usize + 30;
may be wrong.

Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Priority: LowIndicates that an issue or pull request should be resolved behind issues or pull requests labelled `Status: WIPIndicates that an issue is currently being worked on or triaged

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions