fix(test/vulnerabilities): add exception for TSA before 6.1.153 #5458
+26
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5458 +/- ##
=======================================
Coverage 82.76% 82.76%
=======================================
Files 263 263
Lines 27300 27300
=======================================
Hits 22594 22594
Misses 4706 4706
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
force-pushed
the
fix-tsa-vuln-check
branch
4 times, most recently
from
0c61122 to
95dd5c9
Compare
TSA is marked as vulnerable as 6.1 kernels before 6.1.153 don't correctly pass through the CPUID bit to let the guest know that the microcode is applied (CLEAR_VERW). We noticed only now as we just updated the guest kernels and they now contain the TSA mitigation. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Manciukic
force-pushed
the
fix-tsa-vuln-check
branch
from
95dd5c9 to
ac342ed
Compare
Manciukic
added
the
Status: Awaiting review
ShadowCurse
approved these changes
Sep 30, 2025
|
cant we just update the host kernel? |
The AMI wasn't yet available when I checked. This is to unblock the CI. |
JackThomson2
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add an exception for TSA for host kernels before 6.1.153
Reason
Vulnerability checks are failing.
TSA is marked as vulnerable as 6.1 kernels before 6.1.153 don't correctly pass through the CPUID bit to let the guest know that the microcode is applied (CLEAR_VERW).
We noticed only now as we just updated the guest kernels and they now contain the TSA mitigation.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.