Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

[SourceTree] show the webpack icon in the webpack domain directory #2745

Closed
jasonLaster opened this issue Apr 26, 2017 · 6 comments
Closed

Comments

@jasonLaster
Copy link
Contributor

It would be so cool if we could show the webpack icon in the source tree for webpack domains!

@oriharel
Copy link

oriharel commented Apr 26, 2017

I'm working on it!
@jasonLaster - Do you have the .svg resource for me? Thanks!

@jasonLaster
Copy link
Contributor Author

@clarkbw
Copy link
Contributor

clarkbw commented Apr 28, 2017

Got the go ahead from the kind folks at webpack for using the icon!

@amitzur
Copy link
Contributor

amitzur commented May 10, 2017

There's a consistency issue with colored SVG's. I'm just not sure we intended for this visual effect along the source tree in terms of the color.
screen shot 2017-05-10 at 9 31 23

This is also evident in the react logo, which specifies a fill color in itself. But less conspicuous.

One possible solution is to remove the fills from the SVG, but not sure if license permits, plus doesn't always work visually (it doesn't for the webpack logo - it just turns to a full hexagon)

@jasonLaster
Copy link
Contributor Author

Thanks @amitzur, we were just talking about that as well.

I think Atom does a great job of simplifying the icon so that it fits with other icons. I will merge this work as we have done the "hard" thing here and we can create a new issue for using a better SVG and perhaps styling some of the other icons as well. For instance, I think "JS" would be really easy and would help a lot.

screen shot 2017-05-10 at 11 18 14 am

@amitzur
Copy link
Contributor

amitzur commented May 10, 2017

nice work by Atom

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants