Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with BULK_DENSITY at mesh boundaries #13134

Closed
johodges opened this issue Jul 8, 2024 · 3 comments
Closed

Error with BULK_DENSITY at mesh boundaries #13134

johodges opened this issue Jul 8, 2024 · 3 comments
Assignees

Comments

@johodges
Copy link
Collaborator

johodges commented Jul 8, 2024

Describe the bug
The check for zero volume OBST with BULK_DENSITY > 0 fails in some cases with these OBST on mesh boundaries. The attached case has a single obstruction which crosses several mesh boundaries. The OBST has several cells within each mesh so I would not expect it to crash in this manner.

Desktop (please complete the following information):

  • OS: Windows 11
  • Version: Latest master (d5686e6)

simple.txt

@mcgratta mcgratta self-assigned this Jul 8, 2024
@mcgratta
Copy link
Contributor

mcgratta commented Jul 8, 2024

I just saw this same problem with another issue. I have not yet posted the fix but will today.

mcgratta added a commit that referenced this issue Jul 8, 2024
FDS Source: Issue #13134. Fix bug related to thin OBSTs
@mcgratta
Copy link
Contributor

mcgratta commented Jul 8, 2024

Try it now.

@johodges
Copy link
Collaborator Author

johodges commented Jul 8, 2024

Thanks for jumping on this. I can confirm the fix works on the simple case posted here as well as the more complex case on which it was based.

@johodges johodges closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants