Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Uninstall Gateway #4966

Merged
merged 16 commits into from
May 15, 2024
Merged

docs: Uninstall Gateway #4966

merged 16 commits into from
May 15, 2024

Conversation

jamilbk
Copy link
Member

@jamilbk jamilbk commented May 12, 2024

@jamilbk jamilbk requested a review from AndrewDryga May 12, 2024 18:35
Copy link

vercel bot commented May 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
firezone ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 4:03pm

@github-actions github-actions bot added the kind/docs Improvements or updates to documentation label May 12, 2024
Copy link

github-actions bot commented May 12, 2024

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 241.3 MiB (+1%) 243.1 MiB (+1%) 158 (-2%)
direct-tcp-server2client 240.3 MiB (-2%) 241.5 MiB (-2%) 127 (-60%)
relayed-tcp-client2server 232.3 MiB (+3%) 233.6 MiB (+3%) 272 (+20%)
relayed-tcp-server2client 238.6 MiB (-1%) 239.3 MiB (-1%) 398 (+4%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.03ms (+14%) 44.40% (+14%)
direct-udp-server2client 500.0 MiB (-0%) 0.02ms (+31%) 21.88% (-3%)
relayed-udp-client2server 500.0 MiB (-0%) 0.03ms (-38%) 55.60% (-2%)
relayed-udp-server2client 500.0 MiB (+0%) 0.02ms (+51%) 41.13% (+7%)

Copy link

github-actions bot commented May 12, 2024

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
Copy link
Collaborator

@bmanifold bmanifold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tiny grammar things, but other than that LGTM

@jamilbk jamilbk added this pull request to the merge queue May 15, 2024
@bmanifold bmanifold removed this pull request from the merge queue due to a manual request May 15, 2024
jamilbk and others added 2 commits May 14, 2024 22:21
Co-authored-by: Brian Manifold <bmanifold@users.noreply.github.com>
Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
Co-authored-by: Brian Manifold <bmanifold@users.noreply.github.com>
Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
@jamilbk jamilbk added this pull request to the merge queue May 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 15, 2024
jamilbk and others added 5 commits May 15, 2024 08:58
before

<img width="222" alt="Screenshot 2024-05-14 at 6 29 52 AM"
src="https://github.com/firezone/firezone/assets/167144/a9308eca-b6ae-417c-a673-94c7ee8cdec6">

after

<img width="209" alt="Screenshot 2024-05-14 at 8 31 40 AM"
src="https://github.com/firezone/firezone/assets/167144/1de92b63-8679-416a-9014-bf3593d141c4">
Update download links etc for the 1.0.4 release
Why:

* The new flow for creating an identity provider in Firezone allows the
user to not have to worry what features their plan has enabled. It will
allow the user to select which identity provider they use and will take
them to the appropriate form depending on the features they have enabled
on their plan.

## Screenshots

### Selecting an identity provider
<img width="937" alt="Screenshot 2024-05-14 at 11 53 17 AM"
src="https://github.com/firezone/firezone/assets/2646332/31337ad9-13c8-43a2-942c-adb0a951167c">


### New OIDC form when a custom provider is selected but IDP sync is not
enabled for account
<img width="903" alt="Screenshot 2024-05-14 at 11 54 58 AM"
src="https://github.com/firezone/firezone/assets/2646332/2e18d788-60c3-4fad-b749-351559a24aca">
AndrewDryga and others added 5 commits May 15, 2024 08:58
Makes the sync steps optional so the Google, Okta, and Entra guides work
for all plans.

refs #4984
This PR introduces site's `Status`. That's used to report to the client
the status, either, unknown, online or offline, mostly as a hint to
users as what's wrong with a connection.

This are the criteria for an online or offline resource

* If all sites related to a resource are offline the resource is
considered offline, since there's no gateway that can respond to that
resource's connection
* If any site is online the resource is online, since that same peer can
be used to reach that resource
* Any other case is unknown

Right now resources are single site so it doesn't matter too much but
tracking online/offline per-site instead of per-gateway or resource
seems like the better long-term solution.

The way to "find out" the site's status is:

* If a response to a connection details is offline, all sites related to
that resource must be offline otherwise there would've been a gateway in
the response
* At the point we connect to a gateway, the site that corresponds to
that gateway must be online
* When a connection to a peer stops it's considered unknown again

Fixes #4738
@jamilbk jamilbk added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 2ec7034 May 15, 2024
135 checks passed
@jamilbk jamilbk deleted the docs/add-uninstall branch May 15, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/docs Improvements or updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants