-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Uninstall Gateway #4966
Merged
Merged
docs: Uninstall Gateway #4966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Performance Test ResultsTCP
UDP
|
Terraform Cloud Plan Output
|
jamilbk
commented
May 12, 2024
Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
bmanifold
reviewed
May 15, 2024
bmanifold
reviewed
May 15, 2024
bmanifold
approved these changes
May 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of tiny grammar things, but other than that LGTM
Co-authored-by: Brian Manifold <bmanifold@users.noreply.github.com> Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
Co-authored-by: Brian Manifold <bmanifold@users.noreply.github.com> Signed-off-by: Jamil <jamilbk@users.noreply.github.com>
before <img width="222" alt="Screenshot 2024-05-14 at 6 29 52 AM" src="https://github.com/firezone/firezone/assets/167144/a9308eca-b6ae-417c-a673-94c7ee8cdec6"> after <img width="209" alt="Screenshot 2024-05-14 at 8 31 40 AM" src="https://github.com/firezone/firezone/assets/167144/1de92b63-8679-416a-9014-bf3593d141c4">
Update download links etc for the 1.0.4 release
Why: * The new flow for creating an identity provider in Firezone allows the user to not have to worry what features their plan has enabled. It will allow the user to select which identity provider they use and will take them to the appropriate form depending on the features they have enabled on their plan. ## Screenshots ### Selecting an identity provider <img width="937" alt="Screenshot 2024-05-14 at 11 53 17 AM" src="https://github.com/firezone/firezone/assets/2646332/31337ad9-13c8-43a2-942c-adb0a951167c"> ### New OIDC form when a custom provider is selected but IDP sync is not enabled for account <img width="903" alt="Screenshot 2024-05-14 at 11 54 58 AM" src="https://github.com/firezone/firezone/assets/2646332/2e18d788-60c3-4fad-b749-351559a24aca">
Closes #4919 ![image](https://github.com/firezone/firezone/assets/13400041/455bd444-3b75-4bfb-8cc0-afdcd29c55de) ![image](https://github.com/firezone/firezone/assets/13400041/b166fb9a-d7bc-4ac8-8ade-99cebfc7b7a5) ![image](https://github.com/firezone/firezone/assets/13400041/27eff651-08a4-4185-93cc-e1e544595ad8)
Makes the sync steps optional so the Google, Okta, and Entra guides work for all plans. refs #4984
This PR introduces site's `Status`. That's used to report to the client the status, either, unknown, online or offline, mostly as a hint to users as what's wrong with a connection. This are the criteria for an online or offline resource * If all sites related to a resource are offline the resource is considered offline, since there's no gateway that can respond to that resource's connection * If any site is online the resource is online, since that same peer can be used to reach that resource * Any other case is unknown Right now resources are single site so it doesn't matter too much but tracking online/offline per-site instead of per-gateway or resource seems like the better long-term solution. The way to "find out" the site's status is: * If a response to a connection details is offline, all sites related to that resource must be offline otherwise there would've been a gateway in the response * At the point we connect to a gateway, the site that corresponds to that gateway must be online * When a connection to a peer stops it's considered unknown again Fixes #4738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discord.com/channels/1228082899023298741/1239053156965679115