-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Monorepo #191
WIP: Monorepo #191
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the examples aren't published in the package, I'd keep them in the root
.travis.yml
Outdated
script: grunt test | ||
install: | ||
- npm install | ||
- lerna bootstrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in serialport I put this as a postinstall
"postinstall": "lerna bootstrap --no-ci",
no-ci means you don't have to have a package-lock.json
I can't think of a reason why this isn't a good idea
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah-ha! Thank you
@@ -0,0 +1,6 @@ | |||
{ | |||
"packages": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprised that
"lerna": "3.1.4",
isn't a key here? It seems to keep it updated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks
Thanks for pointing this out... I realize now that I need to update all of those anyway. |
@reconbot I've made some changes per your feedback. PTAL—thanks!! |
if we're committing the package-lock.json, it appears out of date with the latest npm. Other than that, 👍 👍 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me, haven't tried to publish, but tests and dev story look good.
🎉 |
this is really good. Could you publish firmata-io? |
I'd like to request a hold on all reviews until @reconbot has had a chance to review and confirm that I've set this up correctly. Thanks in advance