Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Monorepo #191

Merged
merged 14 commits into from
Oct 24, 2018
Merged

WIP: Monorepo #191

merged 14 commits into from
Oct 24, 2018

Conversation

rwaldron
Copy link
Collaborator

I'd like to request a hold on all reviews until @reconbot has had a chance to review and confirm that I've set this up correctly. Thanks in advance

@coveralls
Copy link

coveralls commented Sep 24, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 7f75dd1 on monorepo into 3b3882d on master.

Copy link
Member

@reconbot reconbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the examples aren't published in the package, I'd keep them in the root

.travis.yml Outdated
script: grunt test
install:
- npm install
- lerna bootstrap
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in serialport I put this as a postinstall

    "postinstall": "lerna bootstrap --no-ci",

no-ci means you don't have to have a package-lock.json

I can't think of a reason why this isn't a good idea

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah-ha! Thank you

@@ -0,0 +1,6 @@
{
"packages": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised that

  "lerna": "3.1.4",

isn't a key here? It seems to keep it updated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks

@rwaldron
Copy link
Collaborator Author

If the examples aren't published in the package, I'd keep them in the root

Thanks for pointing this out... I realize now that I need to update all of those anyway.

@rwaldron
Copy link
Collaborator Author

@reconbot I've made some changes per your feedback. PTAL—thanks!!

@reconbot
Copy link
Member

if we're committing the package-lock.json, it appears out of date with the latest npm. Other than that, 👍 👍 👍

Copy link
Member

@reconbot reconbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, haven't tried to publish, but tests and dev story look good.

@rwaldron
Copy link
Collaborator Author

rwaldron commented Oct 23, 2018

@dtex any thoughts?

@monteslu I believe the result of this covers your use cases well

@dtex
Copy link
Contributor

dtex commented Oct 23, 2018

Looks good to me. I defer to @reconbot on the Lerna stuff and I think it's really cool that this handles @monteslu's use case.

@rwaldron
Copy link
Collaborator Author

Thanks @dtex @reconbot

@rwaldron rwaldron merged commit c3b2df4 into master Oct 24, 2018
@reconbot
Copy link
Member

🎉

@monteslu
Copy link
Contributor

this is really good. Could you publish firmata-io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants