Bip47 lelantus #1013

a-bezrukov · 2021-04-13T13:22:20Z

PR intention

An implementation of RAP (bip47) payment codes.

Code changes brief

The secret point is calculated using Lelantus private/public keys. This required a minor change into the Lelantus tx creation. Other that this, there is no significant changes to the existing code and the BIP47 code is done as an add-on.

lgtm-com · 2021-05-31T19:08:38Z

This pull request introduces 13 alerts when merging c50f119 into 677b54c - view on LGTM.com

new alerts:

4 for Overwriting attribute in super-class or sub-class
2 for 'import *' may pollute namespace
2 for Unused local variable
1 for Commented-out code
1 for Declaration hides variable
1 for Missing enum case in switch
1 for Unused static function
1 for No trivial switch statements

lgtm-com · 2021-06-01T20:39:59Z

This pull request introduces 13 alerts when merging 47626f6 into 677b54c - view on LGTM.com

new alerts:

4 for Overwriting attribute in super-class or sub-class
2 for 'import *' may pollute namespace
2 for Unused local variable
1 for Commented-out code
1 for Declaration hides variable
1 for Missing enum case in switch
1 for Unused static function
1 for No trivial switch statements

lgtm-com · 2021-06-02T11:48:38Z

This pull request introduces 13 alerts when merging ecfcbf4 into 677b54c - view on LGTM.com

new alerts:

4 for Overwriting attribute in super-class or sub-class
2 for 'import *' may pollute namespace
2 for Unused local variable
1 for Commented-out code
1 for Declaration hides variable
1 for Missing enum case in switch
1 for Unused static function
1 for No trivial switch statements

lgtm-com · 2021-06-02T18:01:34Z

This pull request introduces 12 alerts when merging cc72c32 into 677b54c - view on LGTM.com

new alerts:

4 for Overwriting attribute in super-class or sub-class
2 for 'import *' may pollute namespace
2 for Unused local variable
1 for Commented-out code
1 for Declaration hides variable
1 for Unused static function
1 for No trivial switch statements

lgtm-com · 2021-06-02T22:20:30Z

This pull request introduces 12 alerts when merging 952262a into 677b54c - view on LGTM.com

new alerts:

4 for Overwriting attribute in super-class or sub-class
2 for 'import *' may pollute namespace
2 for Unused local variable
1 for Commented-out code
1 for Declaration hides variable
1 for Unused static function
1 for No trivial switch statements

lgtm-com · 2021-06-08T14:47:01Z

This pull request introduces 12 alerts and fixes 3 when merging 2bf8657 into 677b54c - view on LGTM.com

new alerts:

4 for Overwriting attribute in super-class or sub-class
2 for 'import *' may pollute namespace
2 for Unused local variable
1 for Commented-out code
1 for Declaration hides variable
1 for Unused static function
1 for No trivial switch statements

fixed alerts:

3 for Unused static function

lgtm-com · 2021-06-08T18:46:29Z

This pull request introduces 12 alerts and fixes 3 when merging 698fb7c into 677b54c - view on LGTM.com

new alerts:

4 for Overwriting attribute in super-class or sub-class
2 for 'import *' may pollute namespace
2 for Unused local variable
1 for Commented-out code
1 for Declaration hides variable
1 for Unused static function
1 for No trivial switch statements

fixed alerts:

3 for Unused static function

psolstice · 2021-06-09T06:23:10Z

src/wallet/wallet.cpp

+    }
+}
+
+void SendNotificationTxLelantus(CWallet * const pwallet, bip47::CPaymentChannel const & pchannel, CWalletTx& wtxNew)


Definitely should be a method of CWallet class.

I think it should not. If speak about PrepareAndSendNotificationTx, then maybe it should. But what for, what would be the benefits of this? It's a utility function as it just uses ::CWallet services to send a very special transaction.

psolstice · 2021-06-09T06:27:24Z

src/wallet/wallet.cpp

@@ -6936,3 +7337,137 @@ bool CMerkleTx::AcceptToMemoryPool(const CAmount &nAbsurdFee, CValidationState &

 bool CompSigmaHeight(const CSigmaEntry &a, const CSigmaEntry &b) { return a.nHeight < b.nHeight; }
 bool CompSigmaID(const CSigmaEntry &a, const CSigmaEntry &b) { return a.id < b.id; }
+
+namespace {
+//I am leaving this proc in place as it may be useful for further urgent cases.


What was the original urgent case? Comment doesn't look good. Please consider removing the function altogether.

It is Lelantus disabled.

I'll save it into some other repo

lgtm-com · 2021-06-09T11:09:59Z

This pull request introduces 11 alerts when merging cc5d57f into 677b54c - view on LGTM.com

new alerts:

4 for Overwriting attribute in super-class or sub-class
2 for 'import *' may pollute namespace
2 for Unused local variable
1 for Commented-out code
1 for Declaration hides variable
1 for No trivial switch statements

Rasikh Morani and others added 30 commits December 17, 2019 14:22

Add bip47

9c9b047

Merge branch 'master' into feature/rap

ed1ad93

Update walletdb.cpp

23eeddb

Update wallet.h

ec3a8b3

Fix Permissions Issue

291dc36

Add Space to Trigger Jenkins

c4e4d10

Remove Comments #1

787042b

Remove Extraneous Comments from Recent Payments

df5ae1e

Remove Comments from BIP47 Util

61de989

Remove Extraneous Comments

09ed530

Remove Extraneous Comments from the Channel File

33ed23f

Remove Extraneous Comments from Payment Code Page

9a73197

Remove Extraneous Comments in Walletmodel

4d57355

Remove Extra Comments

b37f7a5

Remove Extra Comments Related to Old PK Material

ac7821b

Update addressbookpage.cpp

6f6e9aa

Remove Commented Code and Add Comment

c7dc81b

Comment Intentionally Empty if Statement

93b6a7b

Suppress False Flags and Remove Commented Code

31c297b

Remove Comments

2447334

Remove Comments and Surpress False Alarms in Wallet and QT Folder

170657d

Remove Comments and LGTM Alerts

7664a4a

Porting Bip47 to Core14

5da48dd

remove unused codes

dab422d

A little polishing

1223523

remove unused code

866a804

fix error in extracting designated public key in P2PK script

d3bdc7c

remove unused function importBip47PaymentChannelData

d22179e

fix bugs in address book

564e66a

disable delete/edit/new on payment code book

4cf2852

a-bezrukov added 2 commits May 31, 2021 18:57

GUI: wording change

aa1ca4f

GUI: wording change

282d10b

a-bezrukov force-pushed the bip47_lelantus branch from 1670b98 to 282d10b Compare May 31, 2021 15:13

Fixing macos build

c50f119

GUI: Transaction page now supports pcodes

47626f6

Fixing typo and uninitialized value

ecfcbf4

a-bezrukov added 2 commits June 2, 2021 15:51

GUI: minor fixes and improvements

72e15e7

GUI: typo fixes

cc72c32

GUI: minor size fixes

952262a

levonpetrosyan93 previously approved these changes Jun 7, 2021

View reviewed changes

a-bezrukov dismissed levonpetrosyan93’s stale review via 2bf8657 June 8, 2021 11:37

Locking the notification tx output

698fb7c

a-bezrukov force-pushed the bip47_lelantus branch from 2bf8657 to 698fb7c Compare June 8, 2021 15:44

psolstice requested changes Jun 9, 2021

View reviewed changes

a-bezrukov added 2 commits June 9, 2021 11:10

Dealing with code review comments

67a5377

Dealing with code review comments

cc5d57f

psolstice approved these changes Jun 9, 2021

View reviewed changes

levonpetrosyan93 approved these changes Jun 9, 2021

View reviewed changes

reubenyap merged commit e2c8db6 into master Jun 9, 2021

reubenyap deleted the bip47_lelantus branch June 9, 2021 14:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bip47 lelantus #1013

Bip47 lelantus #1013

a-bezrukov commented Apr 13, 2021

lgtm-com bot commented May 31, 2021

lgtm-com bot commented Jun 1, 2021

lgtm-com bot commented Jun 2, 2021

lgtm-com bot commented Jun 2, 2021

lgtm-com bot commented Jun 2, 2021

lgtm-com bot commented Jun 8, 2021

lgtm-com bot commented Jun 8, 2021

psolstice Jun 9, 2021

a-bezrukov Jun 9, 2021

psolstice Jun 9, 2021

a-bezrukov Jun 9, 2021

a-bezrukov Jun 9, 2021

lgtm-com bot commented Jun 9, 2021

Bip47 lelantus #1013

Bip47 lelantus #1013

Conversation

a-bezrukov commented Apr 13, 2021

PR intention

Code changes brief

lgtm-com bot commented May 31, 2021

lgtm-com bot commented Jun 1, 2021

lgtm-com bot commented Jun 2, 2021

lgtm-com bot commented Jun 2, 2021

lgtm-com bot commented Jun 2, 2021

lgtm-com bot commented Jun 8, 2021

lgtm-com bot commented Jun 8, 2021

psolstice Jun 9, 2021

Choose a reason for hiding this comment

a-bezrukov Jun 9, 2021

Choose a reason for hiding this comment

psolstice Jun 9, 2021

Choose a reason for hiding this comment

a-bezrukov Jun 9, 2021

Choose a reason for hiding this comment

a-bezrukov Jun 9, 2021

Choose a reason for hiding this comment

lgtm-com bot commented Jun 9, 2021