Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minimum height issue #1152

Merged
merged 7 commits into from
Apr 3, 2022
Merged

Fixed minimum height issue #1152

merged 7 commits into from
Apr 3, 2022

Conversation

levonpetrosyan93
Copy link
Contributor

Fix for issue #1112

@justanwar
Copy link
Member

Tested. Main wallet window minimum height reduced but recovery UI is still tall.

Need testing on 1366x768 screens.

@levonpetrosyan93
Copy link
Contributor Author

Tested on 1280x800

@justanwar
Copy link
Member

Tested on 1280x768, mnemonic recovery screen shows fully.

@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2022

This pull request fixes 1 alert when merging 425accc into 904984e - view on LGTM.com

fixed alerts:

  • 1 for Unused static function

@KuroGuo
Copy link
Contributor

KuroGuo commented Apr 1, 2022

Tested on 1280x768 (Windows 11, zh-CN) and also 2560x1440 175%, 1920x1080 125%, mnemonic recovery screen shows fully.

image

@reubenyap reubenyap merged commit 532346c into master Apr 3, 2022
@reubenyap reubenyap deleted the height-fix branch April 3, 2022 16:33
levonpetrosyan93 added a commit that referenced this pull request May 17, 2023
* Fixed minimum height issue

* Recovery page height reduced

* One more try to fix recovery window height

* Reducing font size on Recovery window when screen has low resolution

* Making GroupElement deserialize test stable

* Review comment applied
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants