Allow one transaction to pass checks without script verification #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-bezrukov
approved these changes
Jan 28, 2021
levonpetrosyan93
approved these changes
Jan 28, 2021
|
This pull request introduces 3 alerts when merging 8f66384 into 5525561 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Dealing with 51% attack we locked attacker's funds.
https://forum.firo.org/t/firo-51-attack-post-mortem-and-vote-on-attackers-funds/1084
In order to reimburse losses of our users we need to transfer ownership of these funds.
Code changes brief
One transaction created in advance with txid of
3ecea345c7b174271bbdcde8cad6097d9a3dc420259743d52cc9cf1945aaba03is allowed to circumvent normal verification process and go through without script checks