-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use more than 4 rows for completions #2698
Comments
Supporting this customization is an easy change, but I doubt you will see it in fish, because fish tries to keep configuration options to a minimum. Your chances increase if you get more people who think that it should be customizable to comment here. Since this is free software, you are always free to do whatever you want with your own copy. |
I concur with @oranja that this should not be user configurable. This is the type of thing that fish should dynamically configure based on its environment (e.g., the number of rows displayed by the terminal). Assuming enough people feel this should be dynamically sized the question is what should the algorithm be? Should it be scaled linearly to the number of terminal rows; e.g., one autosuggestion line for every six terminal rows? Or should a non-linear equation be used; e.g., 4 autosuggestion lines for terminals up to 30 rows plus one line for every additional four rows up to a maximum of 10 lines? Note that I pulled those numbers out of the air to stimulate discussion and do not mean to imply I think those are good choices. |
Thank you @oranja and @krader1961. I think the fundamental problem may be a bit more than just the number of lines that are being shown. The problem is that the suggestions are not that useful but at the same time you want to avoid that the shell input moves too much. Also, there are many more options that just a fixed number of lines. The suggestions could just take as much space as is available. Or they could use as much space as they need (up to the whole screen size). This seems to be the default in my zsh setup. However, zsh also shows the most common command rather than a random selection. At least for me, fish shows three columns on a large screen and shows the first 4 rows from three columns that wrap somewhere I can't see it. this means some random commands starting with a, then f, then r. This is very arbitrary and I can't imagine that I find a useful command in that list. Moreover, because the suggestions are in three columns, it is hard to read them. Compare to the suggestions from zsh. Overall, I think I wish fish would show the most useful commands on the first tab and then all commands on the second tab. The most useful suggestions could either be a fixed number, fill the shell (and if there is no space, use n lines but also don't show more than m lines), or always fill the whole screen (move the input to the top. I prefer a fixed number that actually doesn't change with the screen size because what I can read doesn't change with the size. |
+1 to this. I'd even be fine with the option to write my own function for how to display suggestions. |
This removes that bit where we only show 4 rows at most at first, instead we disclose up to the full terminal height. This results in less pressing of tab to get the other results, and better visibility of results. However, it also means that it'll push the shell up to the top of the terminal a lot. So this is an experiment to see how that works in practice. Fixes fish-shell#2698
This removes that bit where we only show 4 rows at most at first, instead we disclose up to the full terminal height. This results in less pressing of tab to get the other results, and better visibility of results. However, it also means that it'll push the shell up to the top of the terminal a lot. So this is an experiment to see how that works in practice. Fixes fish-shell#2698
* Disclose pager to screen height immediately This removes that bit where we only show 4 rows at most at first, instead we disclose between half of terminal height up to the full terminal height (but still at least 4 rows). This results in less pressing of tab to get the other results, and better visibility of results. Unlike moving it to the actual top of the screen, it's not as jarring and doesn't push terminal history off-screen as much. Fixes #2698
I have a large screen and would like to use more than 4 rows for autosuggestions.
I know tat I can hit tab again to get the complete list.
The text was updated successfully, but these errors were encountered: