New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds dnf completions for package installs #2638

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@erdosboti
Copy link
Contributor

erdosboti commented Dec 28, 2015

On Fedora 23 I experienced that yum autocompletions works but dnf doesn't. Adding this dnf file seems to solve the issue.

@faho

This comment has been minimized.

Copy link
Member

faho commented Dec 28, 2015

Doesn't dnf accept the exact same arguments as yum? In that case it'd be a bit simpler to just use complete -c dnf -w yum, no?

@erdosboti

This comment has been minimized.

Copy link
Contributor

erdosboti commented Dec 28, 2015

To be honest I'm new to Fedora and also did not really look into fish internals, so I guess what you suggest must be the correct solution :)

@faho

This comment has been minimized.

Copy link
Member

faho commented Dec 28, 2015

I maybe should have explained that - the "-w" or "--wraps" option inherits completions from another command.

It makes fish handle dnf completions just like yum, which seems to be the right thing.

@faho

This comment has been minimized.

Copy link
Member

faho commented Dec 29, 2015

Merged as bb932a0. Thanks!

@faho faho closed this Dec 29, 2015

@zanchey zanchey added this to the 2.3.0 milestone May 20, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment