Only link urls #3827
Closed
Only link urls #3827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tronsmit
force-pushed
the
only-link-URLs
branch
6 times, most recently
from
acb2c82 to
3935883
Compare
This has to be interim. Strategy should be to isolate all REGEX_URL matches, escape the rest and rebuild with matches now tagged as links
1. Find all urls in $canonical 2. Escape everything else 3. Combine in order with urls tagged, but not escaped
Codecov Report
@@ Coverage Diff @@
## main #3827 +/- ##
============================================
- Coverage 22.44% 22.43% -0.01%
Complexity 11503 11503
============================================
Files 1533 1535 +2
Lines 47741 47750 +9
============================================
Hits 10715 10715
- Misses 37026 37035 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to address: #3814
Final commit is a one-line preg_replace implementation