Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file/dir ambiguity #32

Merged
merged 6 commits into from
Jun 10, 2020
Merged

Fix file/dir ambiguity #32

merged 6 commits into from
Jun 10, 2020

Conversation

fishi0x01
Copy link
Owner

@fishi0x01 fishi0x01 commented Jun 10, 2020

Fixes #29

Vault allows for a key to be part of another namespace path, like:

secret/a
secret/a/b

This leads to ambiguous behaviour, e.g., when using rm.

Further, this PR adds integration tests which cover this ambiguity.

@fishi0x01 fishi0x01 self-assigned this Jun 10, 2020
@fishi0x01 fishi0x01 force-pushed the fishi0x01/identical-path-bug branch 2 times, most recently from c025cdd to e7e8c67 Compare June 10, 2020 21:12
@fishi0x01 fishi0x01 force-pushed the fishi0x01/identical-path-bug branch from e7e8c67 to 95f299f Compare June 10, 2020 21:20
@fishi0x01 fishi0x01 force-pushed the fishi0x01/identical-path-bug branch from 413e4f1 to 65205e1 Compare June 10, 2020 23:07
@fishi0x01 fishi0x01 force-pushed the fishi0x01/identical-path-bug branch from fa5a258 to a40190f Compare June 10, 2020 23:32
@fishi0x01 fishi0x01 marked this pull request as ready for review June 10, 2020 23:48
@fishi0x01 fishi0x01 merged commit 857611c into master Jun 10, 2020
@fishi0x01 fishi0x01 deleted the fishi0x01/identical-path-bug branch June 10, 2020 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug when deleting secret named identically to a path
1 participant