Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding dry-run/confirm flags to the 'add' command #91

Merged
merged 2 commits into from
Feb 27, 2021
Merged

Adding dry-run/confirm flags to the 'add' command #91

merged 2 commits into from
Feb 27, 2021

Conversation

dugshnay
Copy link
Contributor

Adding similar behavior from the 'replace' command for --dry-run and --confirm args.

mattlqx
mattlqx reviewed Feb 25, 2021
View reviewed changes
Copy link
Collaborator

@mattlqx mattlqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me aside from the CC feedback. It does look like it's false-positively erroring on the import like it did to me last pull tho. :\

doc/commands/add.md Outdated
@@ -1,7 +1,7 @@
# add

```text
add [-f|--force] KEY VALUE PATH
add [-f|--force] [-y|--commit] [-n|--dry-run] KEY VALUE PATH
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--confirm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! 🙇

I agree with @mattlqx. CC is behaving strange lately for go vet. I was running go vet locally on your branch and everything works fine. Concerning the return statement limit excess: i think it is fine here. I will mark both CC issues as resolved.

Please only adjust the typo mentioned above :)

Will do. Thank you!

@fishi0x01 fishi0x01 added the enhancement New feature or request label Feb 26, 2021
@fishi0x01
Copy link
Owner

Thank you for the contribution! 🙇

I agree with @mattlqx. CC is behaving strange lately for go vet. I was running go vet locally on your branch and everything works fine. Concerning the return statement limit excess: i think it is fine here. I will mark both CC issues as resolved.

Please only adjust the typo mentioned above :)

fishi0x01
fishi0x01 approved these changes Feb 27, 2021
View reviewed changes
Copy link
Owner

@fishi0x01 fishi0x01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you!

@fishi0x01 fishi0x01 merged commit a230fa9 into fishi0x01:master Feb 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattlqx mattlqx mattlqx left review comments

@fishi0x01 fishi0x01 fishi0x01 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dugshnay @fishi0x01 @mattlqx