Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JSON comments #44

Closed
wants to merge 2 commits into from
Closed

Support JSON comments #44

wants to merge 2 commits into from

Conversation

tib
Copy link
Contributor

@tib tib commented Jul 19, 2013

i've created a jsonminify lib, and integrated it to this project, now you can add real comments to the config file.

See #6

@fitztrev
Copy link
Owner

Thank you for the contribution.

I'm leaning toward wontfix for now. I'd like to keep the JSON structure valid for possible easy integration with other applications. But I'm interested in hearing feedback if others feel differently.

@getify
Copy link

getify commented Jul 20, 2013

I won't repeat my comments from the other thread, but just link to them.

Bottom line: Crockford himself suggests exactly what I'm suggesting: strip comments before parsing, perfectly a sane approach for human maintainable config files.

@thoro thoro mentioned this pull request Jul 22, 2013
@hkdobrev
Copy link

hkdobrev commented Aug 4, 2013

As an example of such usage Sublime Text keeps its configuration in JSON files. Their purpose is to be human-maintained. So Sublime Text allows comments in the JSON file and ignores them on parsing.

@fitztrev
Copy link
Owner

fitztrev commented Mar 3, 2015

Thank you very much for the contribution. At this point, I don't believe this functionality is necessary. See my additional comments in #6.

@fitztrev fitztrev closed this Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants