Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target selector #40

Merged
merged 2 commits into from
Oct 27, 2020
Merged

Target selector #40

merged 2 commits into from
Oct 27, 2020

Conversation

dschwen
Copy link
Collaborator

@dschwen dschwen commented Apr 25, 2017

Adds a target selector to choose a valid make target:

image

This runs make and obtains a list of valid targets. It supports arbitrarily complex makefiles (e.g. include directives that generate targets and variable targets).

Replaces #35

I'm putting this out here for comments. There is a little more work to do to correctly deal with abort and running make while the target list is obtained

@dschwen
Copy link
Collaborator Author

dschwen commented Oct 27, 2020

Whatever happened to this PR...

@fiveisprime
Copy link
Owner

I never merged it because it was marked as wip 🤣

Are you ready for it? I'm going to have to figure out how to publish this too.

@dschwen
Copy link
Collaborator Author

dschwen commented Oct 27, 2020

Let me see if this still rebases cleanly and rethink what I meant by "There is a little more work to do to correctly deal with abort and running make while the target list is obtained". Good to see you're still around :-)

@fiveisprime
Copy link
Owner

Sounds good and of course! I'm working on a competing product, but definitely keeping this alive. :)

@dschwen dschwen changed the title [WIP] Target selector Target selector Oct 27, 2020
@dschwen
Copy link
Collaborator Author

dschwen commented Oct 27, 2020

Ok, this PR seems fine. What's the competing product?

Oh, you work on VSCode! Yeah, I've started looking at that as well. But I'm so deeply invested in the Atom plugin ecosystem (with a smart autocomplete for an open source finite element framework) that I'm dreading to relearn the VSCode plugin system.

Intellisense would be nice to have though.

@fiveisprime fiveisprime merged commit a85261d into fiveisprime:master Oct 27, 2020
@fiveisprime
Copy link
Owner

And it's published! Fun fact: apm uses the repository field in package.json to publish the tag and if it doesn't like that format, you get a misleading error. 😅

Let me know if you'd ever like to dig into the extension API in VS Code. The getting started docs are quite good. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants