Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a shadow voting system #110

Merged
merged 18 commits into from
Aug 31, 2014
Merged

Create a shadow voting system #110

merged 18 commits into from
Aug 31, 2014

Conversation

flagbug
Copy link
Owner

@flagbug flagbug commented Aug 28, 2014

This PR introduces a "shadow voting" system.
This means adding a song to the playlist as guest costs a vote, without actually voting on the song and thereby changing it's index in the playlist

Todo:

  • Remove the playlist timeout, since we're moving to the new system
  • Rename the voting system to "guest system"
  • The guest system should only be able to be activated if there's a password set. Otherwise everyone has administrator rights anyway.
  • Warn the user if there's a blank password set, since the administrator access won't work otherwise.
  • Fix all the tests
  • Reflect these changes in the mobile API
  • Write five million more tests

@flagbug flagbug added this to the Remote Control API milestone Aug 30, 2014
flagbug added a commit that referenced this pull request Aug 31, 2014
Create a shadow voting system
@flagbug flagbug merged commit 0282f7a into master Aug 31, 2014
@flagbug flagbug deleted the shadow-voting branch August 31, 2014 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant